Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: authentication middleware for the GoCert server #42

Merged
merged 8 commits into from
Jul 12, 2024
Merged

feat: authentication middleware for the GoCert server #42

merged 8 commits into from
Jul 12, 2024

Conversation

kayra1
Copy link
Contributor

@kayra1 kayra1 commented Jul 10, 2024 •
edited
Loading

Description

This PR implements the authentication and permission functionality described in TE091. The /metrics and /status endpoints are left unauthenticated, as well as the first POST request to the api/v1/accounts endpoint. For more details, please read TE091.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that validate the behaviour of the software
  • I validated that new and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@kayra1 kayra1 marked this pull request as ready for review July 11, 2024 07:21
@kayra1 kayra1 requested a review from a team as a code owner July 11, 2024 07:21
saltiyazan
saltiyazan requested changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@saltiyazan saltiyazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I ran into one issue while testing that I commented

internal/api/middleware.go Show resolved Hide resolved
internal/api/middleware.go Outdated Show resolved Hide resolved
@kayra1 kayra1 requested a review from saltiyazan July 11, 2024 11:09
@kayra1 kayra1 requested a review from gruyaume July 11, 2024 11:50
@kayra1 kayra1 merged commit d16dd50 into main Jul 12, 2024
11 checks passed
@kayra1 kayra1 deleted the tlseng-289 branch July 12, 2024 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saltiyazan saltiyazan saltiyazan approved these changes

@gruyaume gruyaume Awaiting requested review from gruyaume

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kayra1 @saltiyazan